-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try default gcc
9.4.0 to see if it exhibits the same compiler bugs.
#8394
Conversation
d439927
to
620f279
Compare
Thanks for the work! |
6f8062d
to
f8b1ad6
Compare
Using And the PR's Travis CI is passing. However, I see the used gcc version is actually not
So, I think a possible fix is to add the
Or to use the default gcc (= version 9.4.0). I like this way, because it's simple and is aligning with the current RubyCI Ubuntu ppc64le and s390x.
What do you think? Could you change the code? |
When we fix on the 2nd way, I think the PR title can be like this. "Try the system gcc 9.4.0 to see if it exhibits the same compiler bugs." or "Try the default gcc 9.4.0 to see if it exhibits the same compiler bugs." |
Can you change the commit message in the 2 commits to change the gcc-9 to gcc, including the keyword "Travis" and "ppc64le" and "s390x" and explaining the context and reasons? I think squashing the 2 commits to 1 commit is better, because it comes from the same reason, right? The message can be like this. You can check how the commit messages are written in the past in these kind of cases by the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented. Thanks!
I think you can commit to my branch if you want. Let me give you access. |
I am a bit sick today. So, if you want to merge this PR today, I hope you change the PR by yourself. If you are fine to merge this PR next week, I try to update your branch. I am not sure if I can update your branch today. |
@ioquatix I changed my mind. I am working to update your branch now. |
f8b1ad6
to
61f9cf7
Compare
gcc-9
to see if it exhibits the same compiler bugs.default gcc 9.4.0
to see if it exhibits the same compiler bugs.
I rebased the PR. Let's see the results of the Travis CI I confirmed the rebased commit uses the default gcc 9.4.0 as I expected in my forked repository's Travis in advance. |
default gcc 9.4.0
to see if it exhibits the same compiler bugs.gcc
9.4.0 to see if it exhibits the same compiler bugs.
…390x. Use gcc 9.4.0 instead of gcc-10 to avoid the current failures by a possible GCC 10 compiler bug in the Travis ppc64le and s390x cases. And it also aligns with RubyCI Ubuntu ppc64le and s390x where the default gcc is used. Co-authored-by: Jun Aruga <jaruga@ruby-lang.org>
61f9cf7
to
f3f70f4
Compare
All right. I executed Travis 2 times for this PR on ruby/ruby Travis. And I see ppc64le and 390x cases pass in the both 1st and 2nd time. https://app.travis-ci.com/github/ruby/ruby/builds/265796147 |
Related to: ruby/ruby#8394
Related to: ruby/ruby#8394
If #8393 works, let's try
gcc-9
to see if that mitigates the issue too. Perhaps this was a bug introduced ingcc-10
.